Conversation
Replace rb_str_freeze (implicit freeze) with sv_check_frozen_string (explicit check) — backing strings must now be frozen before being passed to StringView.new, Pool.new, or reset!. This prevents silent mutation of strings that views point into. - Merge sv_check_string + sv_check_frozen into sv_check_frozen_string - Update all tests to pass frozen strings - Update README to document the frozen requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backing strings must now be frozen before being passed to
StringView.new,Pool.new, orreset!. Previously these methods would silently freeze the string — now they raiseFrozenErrorif it isn't already frozen.This prevents silent mutation of the caller's string and makes the ownership contract explicit: you freeze the string, then create views into it.
String#view(viarequire "string_view/core_ext") continues to freeze implicitly as a convenience.Changes
rb_str_freeze(implicit) withsv_check_frozen_string(explicit check) at all 3 entry pointssv_check_string+sv_check_frozeninto a singlesv_check_frozen_stringinline helperFrozenError